[
https://issues.apache.org/jira/browse/CASSANDRA-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-16613:
----------------------------------------
Status: Ready to Commit (was: Review In Progress)
+1 LGTM. If I remember right, {{ViewComplexTest}} has long been flaky due to
timeouts on anything less than the XLarge plan. It would be nice if it wasn't
necessary, but raising the timeout is the most pragmatic solution so I'm fine
with it. Also +1 to changing the in-jvm dtests to use {{CURRENT}}, I can't
think of any reason that isn't the right thing to do.
> ProtocolVersion.V4 is still used in places in the code
> ------------------------------------------------------
>
> Key: CASSANDRA-16613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16613
> Project: Cassandra
> Issue Type: Bug
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-rc2, 4.0-rc
>
>
> While working on CASSANDRA-16567, [~adelapena] observed that
> _ProtocolVersion.V4_ is used in _ViewTest_.
> I decided to do a quick grep and observed a list of places where we still
> refer to V4 and it seems at least in many of the tests that was left not
> intentionally.
> This ticket is to verify the usage of _ProtocolVersion.V4_ in the codebase
> and bump it to V5 or default version, similar to what was done in
> CASSANDRA-16567, wherever there is a need.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
