[
https://issues.apache.org/jira/browse/CASSANDRA-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342743#comment-17342743
]
Andres de la Peña edited comment on CASSANDRA-16653 at 5/11/21, 6:30 PM:
-------------------------------------------------------------------------
The proposed [PR|https://github.com/apache/cassandra-dtest/pull/136] changes
the dtest to not use compact storage when the origin version is >= 4.0,
although previous version will still do it.
Maybe it would have been preferable to skip the compact storage part only in
origin versions between {{4.0-beta4}} and {{4.0-rc1}}, which is where the bug
is, but AFAIK there isn't an easy way to get that from the cluster version.
Nevertheless, I don't think that compact storage is an important part of the
4.0-4.0/4.x counters upgrade path, and we already have our new JVM dtest for
dropping compact storage in 4.0/4.x counter tables.
CI is running:
Jenkins:
*
[3.0|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/764/pipeline]
*
[3.11|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/765/pipeline]
*
[4.0|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/762/pipeline]
*
[trunk|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/763/pipeline]
CircleCI:
*
[3.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/450/workflows/65855969-e4e5-4dd8-b9cb-226f641f99cd]
*
[3.11|https://app.circleci.com/pipelines/github/adelapena/cassandra/448/workflows/19b48d88-64ad-4981-8f30-ea2d6f3a0cc5]
*
[4.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/449/workflows/af262f01-bf4c-47b6-bf5d-7b4c6ce837ae]
*
[trunk|https://app.circleci.com/pipelines/github/adelapena/cassandra/451/workflows/b5ae904a-45cf-4118-8614-0ad40ff9ac08]
was (Author: adelapena):
The proposed [PR|https://github.com/apache/cassandra-dtest/pull/136] changes
the dtest to not use compact storage when the origin version is >= 4.0,
although previous version will still do it.
Maybe it would have been preferable to skip the compact storage part only in
origin versions between {{4.0-beta4}} and {{4.0-rc1}}, which is where the bug
is, but AFAIK there isn't an easy way to get that from the cluster version.
Nevertheless, I don't think that compact storage is an important part of the
4.0-4.0/4.x counters upgrade path, and we already have our new JVM dtest for
dropping compact storage in 4.0/4.x counter tables.
CI is running:
CircleCI:
*
[3.0|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/764/pipeline]
*
[3.11|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/765/pipeline]
*
[4.0|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/762/pipeline]
*
[trunk|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/763/pipeline]
Jenkins:
*
[3.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/450/workflows/65855969-e4e5-4dd8-b9cb-226f641f99cd]
*
[3.11|https://app.circleci.com/pipelines/github/adelapena/cassandra/448/workflows/19b48d88-64ad-4981-8f30-ea2d6f3a0cc5]
*
[4.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/449/workflows/af262f01-bf4c-47b6-bf5d-7b4c6ce837ae]
*
[trunk|https://app.circleci.com/pipelines/github/adelapena/cassandra/451/workflows/b5ae904a-45cf-4118-8614-0ad40ff9ac08]
> Multinode counters don't get updated
> ------------------------------------
>
> Key: CASSANDRA-16653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16653
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Counters
> Reporter: Berenguer Blasi
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0-rc2, 4.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A multi node setup with counters doesn't update counters value. Works as
> expected on a single node though. Comes from
> [this|https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/cql_tests.py#L460]
> test. Repro:
> {noformat}
> ccm create counters40
> ccm populate -n 2
> ccm start
> ccm node1 cqlsh
> CREATE KEYSPACE foo WITH REPLICATION = { 'class' :
> 'NetworkTopologyStrategy', 'datacenter1' : 1 } ;
> use foo;
> CREATE TABLE clicks ( userid int, url text, total counter, PRIMARY KEY
> (userid, url) ) WITH COMPACT STORAGE;
> ALTER TABLE clicks DROP COMPACT STORAGE;
> TRUNCATE clicks;
> UPDATE clicks SET total = total + 1 WHERE userid = 1 AND url =
> 'http://foo.com';
> SELECT total FROM clicks WHERE userid = 1 AND url = 'http://foo.com';
> total
> -------
> 1
> UPDATE clicks SET total = total - 4 WHERE userid = 1 AND url =
> 'http://foo.com';
> SELECT total FROM clicks WHERE userid = 1 AND url = 'http://foo.com';
> total
> -------
> 1 *********** Should be '-3'
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
