[ https://issues.apache.org/jira/browse/CASSANDRA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343252#comment-17343252 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16644 at 5/12/21, 1:40 PM: --------------------------------------------------------------------------- bq. Can you please confirm we're talking about the same flaky and this is ready to commit with? I left a few comments in GitHub, most important, please, return the riptano/ccm repo. I used mine in requirements.txt only for test purposes. Thanks bq. I am thinking of just generally raising for all tests those 90s to 120s or 180s. Wdyt? -1. Were have only a few new flakes and raising the timeout for the whole suite doesn't seem right to me. This will lead to even longer CI runs in case of failures. I suggest we first look at those few ones and the reason for flakiness and start from there. was (Author: e.dimitrova): Bq. Can you please confirm we're talking about the same flaky and this is ready to commit with? I left a few comments in GitHub, most important, please, return the riptano/ccm repo. I used mine in requirements.txt only for test purposes. Thanks Bq. I am thinking of just generally raising for all tests those 90s to 120s or 180s. Wdyt? -1. Were have only a few new flakes and raising the timeout for the whole suite doesn't seem right to me. This will lead to even longer CI runs in case of failures. I suggest we first look at those few ones and the reason for flakiness and start from there. > Flaky TestTransientReplicationRing.test_move_backwards_and_cleanup > ------------------------------------------------------------------ > > Key: CASSANDRA-16644 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16644 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python > Reporter: Berenguer Blasi > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0-rc > > > Failure > [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/472/testReport/junit/dtest-novnode.transient_replication_ring_test/TestTransientReplicationRing/test_move_backwards_and_cleanup/] > {noformat} > Error Message > ccmlib.node.TimeoutError: 27 Apr 2021 00:01:00 [node4] after 90.11/90 seconds > Missing: ['Starting listening for CQL clients'] not found in system.log: > Tail: INFO [main] 2021-04-26 23:59:22,590 YamlConfigura > Stacktrace > self = <transient_replication_ring_test.TestTransientReplicationRing object > at 0x7f66c51ebd90> > @flaky(max_runs=1) > @pytest.mark.no_vnodes > def test_move_backwards_and_cleanup(self): > """Test moving a node backwards without moving past a neighbor > token""" > move_token = '00005' > expected_after_move = [gen_expected(range(0, 6), range(31, 40)), > gen_expected(range(0, 21, 2)), > gen_expected(range(1, 6, 2), range(6, 31)), > gen_expected(range(7, 20, 2), range(21, 40))] > expected_after_repair = [gen_expected(range(0, 6), range(31, 40)), > gen_expected(range(0, 21)), > gen_expected(range(6, 31)), > gen_expected(range(21, 40))] > > self.move_test(move_token, expected_after_move, expected_after_repair) > transient_replication_ring_test.py:333: > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > _ > transient_replication_ring_test.py:235: in move_test > node4.start(wait_for_binary_proto=True) > transient_replication_ring_test.py:50: in new_start > return old_start(*args, **kwargs) > ../venv/src/ccm/ccmlib/node.py:901: in start > self.wait_for_binary_interface(from_mark=self.mark) > ../venv/src/ccm/ccmlib/node.py:687: in wait_for_binary_interface > self.watch_log_for("Starting listening for CQL clients", **kwargs) > ../venv/src/ccm/ccmlib/node.py:588: in watch_log_for > TimeoutError.raise_if_passed(start=start, timeout=timeout, node=self.name, > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > _ > start = 1619481570.0236456, timeout = 90 > msg = "Missing: ['Starting listening for CQL clients'] not found in > system.log:\nTail: INFO [main] 2021-04-26 23:59:22,590 YamlConfigura" > node = 'node4' > @staticmethod > def raise_if_passed(start, timeout, msg, node=None): > if start + timeout < time.time(): > > raise TimeoutError.create(start, timeout, msg, node) > E ccmlib.node.TimeoutError: 27 Apr 2021 00:01:00 [node4] after > 90.11/90 seconds Missing: ['Starting listening for CQL clients'] not found in > system.log: > E Tail: INFO [main] 2021-04-26 23:59:22,590 YamlConfigura > ../venv/src/ccm/ccmlib/node.py:56: TimeoutError > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org