[ 
https://issues.apache.org/jira/browse/CASSANDRA-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358826#comment-17358826
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-16690 at 6/7/21, 7:51 PM:
--------------------------------------------------------------------------

BUT here a tiny patch comes. 

I think that the time of 10ms probably sometimes it is not enough for the 
cleaner. I raised the time to 20 MILISECONDS plus added an assertion 
[here|https://github.com/ekaterinadimitrova2/cassandra/pull/136/commits/3888fbace8ae96ab0426853d2583d5adc62a5d97].
 I was not able to reproduce the issue but my assumption is based on reviewing 
the code. 

[~adelapena] or [~maedhroz], does anyone of you have the time to look at this, 
please? As you were reviewing my changes in that area of the code at the 
beginning of the year. This wasn't a new test added but somehow related. 

Thank you in advance. I can't reproduce the issue locally, CircleCI Multiplexer 
and in our company Jenkins multiplexer. I just pushed a CI run in cassandra 
Jenkins, dev - [https://jenkins-cm4.apache.org/job/Cassandra-devbranch/851/] I 
suggest we push the commit if there is no failure in Jenkins. 


was (Author: e.dimitrova):
BUT here a tiny patch comes. 

I think that the time of 10ms probably sometimes it is not enough for the 
cleaner. I raised the time to 20 MILISECONDS plus added an assertion 
[here|https://github.com/ekaterinadimitrova2/cassandra/pull/136/commits/3888fbace8ae96ab0426853d2583d5adc62a5d97].
 I was not able to reproduce the issue but my assumption is based on reviewing 
the code. 

[~adelapena] or [~maedhroz], does anyone of you have the time to look at this, 
please? As you were reviewing my changes in that area of the code at the 
beginning of the year. This wasn't a new test added but somehow related. 

Thank you in advance. I can't reproduce the issue locally, CircleCI Multiplexer 
and in our company Jenkins multiplexer. I just pushed a CI run in cassandra 
Jenkins, dev - 
[https://jenkins-cm4.apache.org/job/Cassandra-devbranch/851/|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/851/[]
 I suggest we push the commit if there is no failure in Jenkins. 

> Flaky NativeAllocatorTest.testBookKeeping
> -----------------------------------------
>
>                 Key: CASSANDRA-16690
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16690
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky 
> [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/52/testReport/junit/org.apache.cassandra.utils.memory/NativeAllocatorTest/testBookKeeping_cdc/]
> {noformat}
> Error Message
> java.lang.AssertionError: expected:<0> but was:<1>
> Stacktrace
> java.util.concurrent.ExecutionException: java.lang.AssertionError: 
> expected:<0> but was:<1>
>       at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
>       at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
>       at 
> org.apache.cassandra.utils.memory.NativeAllocatorTest.testBookKeeping(NativeAllocatorTest.java:154)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.lang.AssertionError: expected:<0> but was:<1>
>       at 
> org.apache.cassandra.utils.memory.NativeAllocatorTest.lambda$testBookKeeping$2(NativeAllocatorTest.java:131)
>       at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>       at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>       at 
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>       at java.base/java.lang.Thread.run(Thread.java:834)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to