[ 
https://issues.apache.org/jira/browse/CASSANDRA-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359176#comment-17359176
 ] 

Berenguer Blasi commented on CASSANDRA-16690:
---------------------------------------------

It's easy to repro adding a Thread.sleep() before {{isClean.countDown()}} in 
the cleaner code. Adding the assertion to check for a successful clean, and 
raising the wait timeout is the way to go +1. But I would raise it to 500ms or 
so, then we won't have to fight this again the day we timeout on 20ms. At the 
end of the day that timeout being high has no semantics.

> Flaky NativeAllocatorTest.testBookKeeping
> -----------------------------------------
>
>                 Key: CASSANDRA-16690
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16690
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky 
> [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/52/testReport/junit/org.apache.cassandra.utils.memory/NativeAllocatorTest/testBookKeeping_cdc/]
> {noformat}
> Error Message
> java.lang.AssertionError: expected:<0> but was:<1>
> Stacktrace
> java.util.concurrent.ExecutionException: java.lang.AssertionError: 
> expected:<0> but was:<1>
>       at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
>       at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
>       at 
> org.apache.cassandra.utils.memory.NativeAllocatorTest.testBookKeeping(NativeAllocatorTest.java:154)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.lang.AssertionError: expected:<0> but was:<1>
>       at 
> org.apache.cassandra.utils.memory.NativeAllocatorTest.lambda$testBookKeeping$2(NativeAllocatorTest.java:131)
>       at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>       at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>       at 
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>       at java.base/java.lang.Thread.run(Thread.java:834)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to