[
https://issues.apache.org/jira/browse/CASSANDRA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363629#comment-17363629
]
Andres de la Peña commented on CASSANDRA-16612:
-----------------------------------------------
I think that the unpatched test is never going to fail because it always has a
load of {{45.84 KiB}}.
[Here|https://app.circleci.com/pipelines/github/adelapena/cassandra/597/workflows/974af381-2c2d-4dc4-a203-4671a1caba64]
are 10K multiplexer rounds showing how at least 4.0.0 seems to be unaffected.
Nevertheless I agree that the regex is incorrect and we should fix it, although
I'm not sure that we need to do it in 4.0.0.
As for the patch, it seems that it contains the cosmetic changes but I think
that [the relevant
change|https://github.com/apache/cassandra/blob/31c1bbe87f8e376f353df2a16881124122045936/test/unit/org/apache/cassandra/tools/nodetool/StatusTest.java#L91]
in the regex is missed.
> RingTest has inconsistent assertion
> -----------------------------------
>
> Key: CASSANDRA-16612
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16612
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Jacek Lewandowski
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> There is an assertion for the node current load like:
> {noformat}
> assertThat(hostRing, matchesPattern(".*\\d+\\.\\d+ KiB.*"));
> {noformat}
> while we are formatting that value with {{#.##}}. Therefore if we say have 46
> KiB, it will be formatted as 46 KiB rather than 46.00 KiB which is expected
> by the test. We need to either change this assertion or change the format
> string to {{#0.00}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
