[ 
https://issues.apache.org/jira/browse/CASSANDRA-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369491#comment-17369491
 ] 

Brandon Williams commented on CASSANDRA-16759:
----------------------------------------------

This makes sense to me too.  Thanks for the summary, [~yifanc].  I do feel that 
this special casing in onJoin may need to be repeated elsewhere and may in 
general be good to always process in this order, but perhaps YAGNI and we can 
look into a custom comparator later if we do. +1

> Avoid memoizing the wrong min cluster version during upgrades
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-16759
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16759
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Coordination
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 4.0-rc2
>
>
> CASSANDRA-16525 avoids trying to calculate the cluster min version if 
> gossiper is not enabled.
> This makes us memoize the wrong version for up to a minute causing us to send 
> 4.0-messages to 3.0 nodes, for example in 
> [ColumnFilter|https://github.com/apache/cassandra/blob/05beda90a9206db165a3997a736ecb06f8dc695e/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L210]
> This was discovered by python upgrade dtests, 
> [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/993/workflows/2afef6f0-1356-41f6-93dc-5385ac19dca1/jobs/5977/tests#failed-test-0]
>  after reverting CASSANDRA-15899 in CASSANDRA-16735



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to