[ 
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381622#comment-17381622
 ] 

Jogesh Anand edited comment on CASSANDRA-16621 at 7/16/21, 3:55 AM:
--------------------------------------------------------------------

+1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly 
assumed that Awaitility would check the condition right before timeout, but 
that's clearly not the case. 
Updated to use a fixed poll interval of ~100ms in the PR. 
Thanks [~bereng] for sharing.  


was (Author: djanand):
+1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly 
assumed that Awaitility would check the condition right before timeout, but 
that's clearly not the case. 
Updated to use a fixed poll interval of ~100ms in the PR. 

> Replace spinAsserts code with Awaitility code
> ---------------------------------------------
>
>                 Key: CASSANDRA-16621
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Jogesh Anand
>            Priority: Normal
>              Labels: low-hanging-fruit
>             Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used 
> more and more. We have now 2 ways of doing the same thing so it would be good 
> to consolidate



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to