[ https://issues.apache.org/jira/browse/CASSANDRA-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054731#comment-13054731 ]
Jonathan Ellis commented on CASSANDRA-2753: ------------------------------------------- Suggest adding a comment that SSTableWriter.append(AbstractCompactedRow row) deliberately avoids calling updateMaxTimestamp b/c otherwise we'd have to deserialize EchoedRow. where is the max-timestamp-of-compacted-sstables logic? I didn't notice it. nit: renaming SSTableWriter.writeMetadata feels gratuitous nit: prefer initializing fields that don't need constructor parameters, at declaration time (looking at RowIndexer.sstMC) > Capture the max client timestamp for an SSTable > ----------------------------------------------- > > Key: CASSANDRA-2753 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2753 > Project: Cassandra > Issue Type: New Feature > Components: Core > Reporter: Alan Liang > Assignee: Alan Liang > Priority: Minor > Attachments: > 0001-capture-max-timestamp-and-created-SSTableMetadata-to.patch, > 0003-capture-max-timestamp-for-sstable-and-introduced-SST.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira