[ 
https://issues.apache.org/jira/browse/CASSANDRA-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396044#comment-17396044
 ] 

Ekaterina Dimitrova commented on CASSANDRA-13720:
-------------------------------------------------

CI looks good. 
bq. 
Removing the unused startTime argument looks good to me, +1. Maybe the cmd 
argument in createQueryThread could also be removed, since it's not used 
anymore.

I left the same comment about _cmd_ in _createQueryThread_ 
[here|https://github.com/apache/cassandra/pull/1126#pullrequestreview-720416704]
 last week. 
My only question is whether we want to do more cleaning of the warnings of that 
class or stick only to the unused arguments?

> Clean up repair code
> --------------------
>
>                 Key: CASSANDRA-13720
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13720
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Consistency/Repair
>            Reporter: Simon Zhou
>            Assignee: Simon Zhou
>            Priority: Normal
>             Fix For: 4.x
>
>
> Lots of unused code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to