[ https://issues.apache.org/jira/browse/CASSANDRA-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399923#comment-17399923 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16835 at 8/16/21, 6:33 PM: --------------------------------------------------------------------------- I think it is a test issue. [~brandon.williams], as you were also involved In CASSANDRA-16013 where [this assertion|https://github.com/ekaterinadimitrova2/cassandra/commit/06aca0e4a995f0fff4e4eac76d1d81d27d181239#diff-702da23770e443ad8b0ac0a4b94c6b9fbf1c3727fcab13b734389e49878ff175L430] (the fix will apply to 4.0 and trunk) was added, can you confirm It, please, that I am not missing anything? was (Author: e.dimitrova): I think it is a test issue. [~brandon.williams], as you were also involved In CASSANDRA-16013 where [this assertion|https://github.com/ekaterinadimitrova2/cassandra/commit/06aca0e4a995f0fff4e4eac76d1d81d27d181239#diff-702da23770e443ad8b0ac0a4b94c6b9fbf1c3727fcab13b734389e49878ff175L430] was added, can you confirm It, please, that I am not missing anything? > Scrub still uses "row" to mean "partitions", and has broken code > ---------------------------------------------------------------- > > Key: CASSANDRA-16835 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16835 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > > 2 issues in the scrub code: > 1) It still uses "row" to mean "partition". And not only in the code, but > also in user messages. As we've fairly systematically remove such instances > elsewhere in 3.0+, having it in scrub is going to confuse users which will > almost surely misinterpret the results. If scrub says that it dropped 2 > unreadable "rows" from your sstable, you might be ok with that when we're > actually talking about CQL rows, but not if we talk of 2 full partitions. > 2) There is a branch at the end of scrub that is supposed to handle the case > where scrubbing a sstable generates no output at all (the sstable is > completely hosed usually), mostly providing a more user friendly message. The > code is broken (and has been for a long time, since CASSANDRA-7066 I believe) > however such that this branch can simply never be taken (even when it > should). While admittedly pretty minor, no reason to leave it that way. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org