[
https://issues.apache.org/jira/browse/CASSANDRA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401386#comment-17401386
]
Tatu Saloranta commented on CASSANDRA-16855:
--------------------------------------------
I added that one unit tests to (try to) ensure that `StatsPrinter` behavior did
not change (there was one special case wrt NaNs). Coverage for other aspects is
probably more limited, at least direct tests.
As to performance I would expect Jackson to at least be not-slower and likely
faster (based on benchmarking I have done over the years) but would not expect
differences to necessarily surface to higher level tests. JSON processing is
probably not big enough part of cpu load for that.
I can find links to external tests but not sure they would help with specific
usage.
But if it was easy enough, could probably add `jmh` based tests for one of
aspects.
> Replace minor use of `json-simple` with Jackson
> -----------------------------------------------
>
> Key: CASSANDRA-16855
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16855
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies, Local/Other, Tool/nodetool
> Reporter: Tatu Saloranta
> Assignee: Tatu Saloranta
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.x
>
>
> Jackson library is used for most JSON reading/writing, but there are couple
> of places where older "json-simple" library is used, mostly for diagnostics
> output. Replacing those minor usages would allow removal of a dependency, one
> for which the last release was made in 2012.
> Places where json-simple is used are:
> * src/java/org/apache/cassandra/db/ColumnFamilyStore.java
> * src/java/org/apache/cassandra/db/commitlog/CommitLogDescriptor.java
> * src/java/org/apache/cassandra/hints/HintsDescriptor.java
> * src/java/org/apache/cassandra/tools/nodetool/stats/StatsPrinter.java
> (and some matching usage in couple of test classes)
> I can take a stab at replacing these uses; it also looks like test coverage
> may be spotty for some (StatsPrinter json/yaml part has no tests for example).
> It is probably best to target this for "trunk" (4.1?).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
