[ 
https://issues.apache.org/jira/browse/CASSANDRA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411102#comment-17411102
 ] 

Stefan Miklosovic commented on CASSANDRA-16790:
-----------------------------------------------

PR looks good however it is little bit tricky to test this because dropped / 
truncated snapshots are not part of the listsnapshots (see CASSANDRA-16843). My 
idea around testing is to create a table with auto_snapshot_ttl set, drop that 
table, list snapshots to see it is there on ttl, wait for some time and list it 
again to see it is not there anymore. However this "listing of dropped / 
truncated" seems to be problematic. 

We were together going through the code and we tried to fix this but changes 
required are quite complex and we do not know how to approach this completely 
and correctly yet.

I would say, lets spend some more time with this ticket and let's try come up 
with the solution to the above problem so we are not committing something 
half-cooked. Maybe trying to fix CASSANDRA-16843 first would be preferable 
approach here.

> Add auto_snapshot_ttl configuration
> -----------------------------------
>
>                 Key: CASSANDRA-16790
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16790
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Local/Config
>            Reporter: Paulo Motta
>            Assignee: Abuli Palagashvili
>            Priority: Normal
>
> This property should take a human readable parameter (ie. 6h, 3days). When 
> specified and {{auto_snapshot: true}}, auto snapshots created should use  the 
> specified TTL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to