[
https://issues.apache.org/jira/browse/CASSANDRA-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411216#comment-17411216
]
Benjamin Lerer commented on CASSANDRA-11323:
--------------------------------------------
I had some look at the patch and I have the following comments:
* The approach to compute the commitlog dir freespace do not handle large file
system
* Logging a separate error message is confusing as the 2 error messages can end
up being separated in the log file. It is probably better in my opinion to
merge the 2 messages together when needed. That will remove the need for the
{{SpamLogger}} as the messages are always logged anyway.
The PR for the modified version on 3.0 can be found
[here|https://github.com/apache/cassandra/pull/1188] and the CI results are
[here|https://app.circleci.com/pipelines/github/blerer/cassandra/200/workflows/c62fb6ed-7bdf-42f6-9e97-aa4a5c4b738d].
[~brandon.williams] Would you mind reviewing my changes?
> When node runs out of commitlog space you get poor log information
> ------------------------------------------------------------------
>
> Key: CASSANDRA-11323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11323
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability
> Reporter: T Jake Luciani
> Assignee: Boris Onufriyev
> Priority: Low
> Labels: fallout
> Attachments: 11323-2.2.txt, 11323-3.0.txt, 11323-3.0.txt,
> 11323-3.11.txt, 11323-3.11.txt, 11323-trunk.txt, 11323-trunk.txt
>
>
> {code}
> ERROR [PERIODIC-COMMIT-LOG-SYNCER] 2016-03-08 20:27:33,899
> StorageService.java:470 - Stopping gossiper
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2016-03-08 20:27:33,899
> StorageService.java:377 - Stopping gossip by operator request
> INFO [PERIODIC-COMMIT-LOG-SYNCER] 2016-03-08 20:27:33,899 Gossiper.java:1463
> - Announcing shutdown
> {code}
> That's all you get when a node runs out of commit log space.
> We should explicitly callout the fact the commitlog is out of disk. I see
> that in the commit log error handler but after it shuts down. So I think it's
> never getting written before shutdown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
