[
https://issues.apache.org/jira/browse/CASSANDRA-16944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415211#comment-17415211
]
Caleb Rackliffe commented on CASSANDRA-16944:
---------------------------------------------
+1 on all patches (although I've left a few minor nits across the PRs)
The test failures I do see are all preexisting issues.
This will merge up to trunk as well, correct?
> Single partition reads can read more SSTables than required
> ------------------------------------------------------------
>
> Key: CASSANDRA-16944
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16944
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> For some scenarios involving row deletions, range deletions or static
> columns, the logic of
> {{SinglePartitionReadCommand.queryMemtableAndSSTablesInTimestampOrder}} might
> trigger more SSTables reads that expected.
> For row deletions and range deletions the reasons is that the logic do not
> take them into account. Once we hit a deleted row (caused by a row deletion
> or a range deletion) with a timestamp higher than the one of the next SStable
> we know that we can stop reading more SSTables.
> For static columns the problems seems to have been introduced by the changes
> in CASSANDRA-16671.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
