[ https://issues.apache.org/jira/browse/CASSANDRA-16969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419003#comment-17419003 ]
Benjamin Lerer commented on CASSANDRA-16969: -------------------------------------------- I have seen following failure of {{test_scrub_collections_table - scrub_test.TestScrubIndexes}} from {{scrub_test.py}} and wonder if it is not related to this patch. {code} test teardown failure Unexpected error found in node logs (see stdout for full details). Errors: [ERROR [CompactionExecutor:1] 2021-09-22 17:50:31,020 CassandraDaemon.java:581 - Exception in thread Thread[CompactionExecutor:1,1,main] java.io.IOError: java.lang.IllegalArgumentException at org.apache.cassandra.db.compaction.Scrubber.throwIfCannotContinue(Scrubber.java:449) at org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:272) at org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1159) at org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:459) at org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:379) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.IllegalArgumentException: null at java.nio.Buffer.limit(Buffer.java:275) at org.apache.cassandra.db.marshal.ByteBufferAccessor.slice(ByteBufferAccessor.java:107) at org.apache.cassandra.db.marshal.ByteBufferAccessor.slice(ByteBufferAccessor.java:39) at org.apache.cassandra.serializers.CollectionSerializer.readValue(CollectionSerializer.java:127) at org.apache.cassandra.serializers.ListSerializer.validateForNativeProtocol(ListSerializer.java:76) at org.apache.cassandra.serializers.CollectionSerializer.validate(CollectionSerializer.java:66) at org.apache.cassandra.db.marshal.AbstractType.validate(AbstractType.java:193) at org.apache.cassandra.db.marshal.AbstractType.validate(AbstractType.java:188) at org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:263) ... 8 common frames omitted, WARN [RMI TCP Connection(8)-127.0.0.1] 2021-09-22 17:50:31,037 ColumnFamilyStore.java:1560 - Rebuilding index for users.user_uuids_idx because of {code} > Scrub does not detect invalid partition keys > -------------------------------------------- > > Key: CASSANDRA-16969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16969 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable > Reporter: Brandon Williams > Assignee: Brandon Williams > Priority: Normal > Fix For: 3.11.12, 4.0.2, 4.1 > > > The standalone scrubber [gets the > key|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/Scrubber.java#L202] > from the file but never validates it, and this will propagate to the new > sstable so it will be corrupted when read later. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org