[
https://issues.apache.org/jira/browse/CASSANDRA-17030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427209#comment-17427209
]
Benjamin Lerer commented on CASSANDRA-17030:
--------------------------------------------
Thanks for the patch [~frankgh]. :-)
There is some addition that are needed to the current patch (unfortunately they
that are not necessary obvious for somebody new to the codebase):
* The new {{RoleSyntaxTest}} tests ensure that the syntax is valid but do not
validate that the permissions are effectively taken into account by the system.
So it will be great to add a test validating that the permissions are
effectively taken into account.
* CQLSH has its own parsing logic for autocompletion in
{{pylib/cqlshlib/cql3handling.py}} and the test to validate autocompletion are
in {{pylib/cqlshlib/test/test_cqlsh_completion.py}}
* As it is an improvements we should add an entry in the {{NEWS.txt}} for 4.1
I have just created a patch for CASSANDRA-17027 that add some tests similar to
what is needed for the first two points. My advise to you would be to build
your patch on top of my branch and to modify the {{GrantAndRevokeTest}} unit
test and the {{test_complete_in_grant}} and {{test_complete_in_revoke}}
autocompletion tests in {{test_cqlsh_completion}}.
Once you have done those changes if you are looking for another patch I would
suggest you CASSANDRA-10537 :-)
> Allow to GRANT or REVOKE multiple permissions in a single statement
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17030
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17030
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
> Reporter: Benjamin Lerer
> Assignee: Francisco Guerrero
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In order to GRANT or REVOKE multiple permissions we are currently forced to
> execute multiple requests. For example:
> {code}
> GRANT MODIFY ON KEYSPACE field TO manager;
> GRANT SELECT ON KEYSPACE field TO manager;
> {code}
> We should be able to perform the same operations on a single request
> {code}
> GRANT MODIFY, SELECT ON KEYSPACE field TO manager;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
