[ 
https://issues.apache.org/jira/browse/CASSANDRA-17029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435123#comment-17435123
 ] 

Kanthi Subramanian commented on CASSANDRA-17029:
------------------------------------------------

[~blerer] Actually nvm the comment above, the rebase only fixes the first 
timestamp test, I was able to reproduce the ambiguous function in the 
validations test, trying to fix it.

org.apache.cassandra.exceptions.InvalidRequestException: Ambiguous call to 
function maxtimeuuid (can be matched by following signatures: 
system.maxtimeuuid : (timestamp) -> timeuuid, system.maxtimeuuid : (bigint) -> 
timeuuid): use type casts to 
disambiguateorg.apache.cassandra.exceptions.InvalidRequestException: Ambiguous 
call to function maxtimeuuid (can be matched by following signatures: 
system.maxtimeuuid : (timestamp) -> timeuuid, system.maxtimeuuid : (bigint) -> 
timeuuid): use type casts to disambiguate
 at 
org.apache.cassandra.cql3.statements.RequestValidations.invalidRequest(RequestValidations.java:217)
 at 
org.apache.cassandra.cql3.functions.FunctionResolver.pickBestMatch(FunctionResolver.java:187)
 at 
org.apache.cassandra.cql3.functions.FunctionResolver.get(FunctionResolver.java:85)
 at 
org.apache.cassandra.cql3.functions.FunctionCall$Raw.prepare(FunctionCall.java:159)
 at 
org.apache.cassandra.cql3.SingleColumnRelation.toTerm(SingleColumnRelation.java:123)
 at 
org.apache.cassandra.cql3.SingleColumnRelation.newSliceRestriction(SingleColumnRelation.java:231)
 at org.apache.cassandra.cql3.Relation.toRestriction(Relation.java:147) at 
org.apache.cassandra.cql3.restrictions.StatementRestrictions.<init>(StatementRestrictions.java:188)
 at 
org.apache.cassandra.cql3.restrictions.StatementRestrictions.<init>(StatementRestrictions.java:135)
 at 
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepareRestrictions(SelectStatement.java:1134)
 at 
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1004)
 at 
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:994)
 at 
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:969)
 at 
org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:591) 
at 
org.apache.cassandra.cql3.QueryProcessor.parseStatement(QueryProcessor.java:276)
 at 
org.apache.cassandra.cql3.QueryProcessor.prepareInternal(QueryProcessor.java:324)
 at 
org.apache.cassandra.cql3.QueryProcessor.executeInternal(QueryProcessor.java:334)
 at 
org.apache.cassandra.cql3.CQLTester.executeFormattedQuery(CQLTester.java:1156) 
at org.apache.cassandra.cql3.CQLTester.execute(CQLTester.java:1144) at 
org.apache.cassandra.cql3.validation.entities.TimeuuidTest.testTimeuuid(TimeuuidTest.java:67)
 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method) at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.base/java.lang.reflect.Method.invoke(Method.java:566) at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
 at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
 at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
 at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
 at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) 
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) 
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) 
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) 
at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at 
org.junit.runner.JUnitCore.run(JUnitCore.java:137) at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
 at 
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
 at 
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
 at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)

> Add unix time conversion functions
> ----------------------------------
>
>                 Key: CASSANDRA-17029
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17029
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Syntax
>            Reporter: Benjamin Lerer
>            Assignee: Kanthi Subramanian
>            Priority: Normal
>
> It will be useful to have some functions to conver unix time values into C* 
> native types, like:
> *     {{toDate(bigint)}} 
> *     {{toTimestamp(bigint)}}
> *     {{mintimeuuid(bigint)}}
> *     {{maxtimeuuid(bigint)}}
> +Additional info for newcomers:+
> Those new functions need to be added to 
> {{org.apache.cassandra.cql3.functions.TimeFcts}} and some unit tests need to 
> be added to {{org.apache.cassandra.cql3.functions..TimeFctsTest}}. The other 
> functions in {{TimeFcts}} provide some good example of how to create new 
> functions.
> As it is a new functionality they need to be mentioned in the {{NEWS.txt}} 
> file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to