[ https://issues.apache.org/jira/browse/CASSANDRA-17117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438311#comment-17438311 ]
Doug Rohrer commented on CASSANDRA-17117: ----------------------------------------- Here are all the workflows in Circle CI - I've approved all of the pre-commit ones - will take time to work through the queue I'm sure. Trunk JDK11 - https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra/3/workflows/581de388-4488-4789-8880-95d7faab7877 JDK8 - https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra/3/workflows/475b6807-199c-4cf0-a9e6-e2b63fc4e65d 4.0 JDK11 - https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra/2/workflows/3efa087e-75e8-4794-99be-64c6475e3cab JDK8 - https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra/2/workflows/81e8a3ac-96ff-46a6-9c4c-0f5e68bdb276 > CQLSSTableWriter backwards compatibility fix for Date fields > ------------------------------------------------------------ > > Key: CASSANDRA-17117 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17117 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable > Reporter: Doug Rohrer > Assignee: Sam Tunnicliffe > Priority: Normal > Attachments: CASSANDRA-17117-4.0.patch, CASSANDRA-17117-trunk.patch > > > {{cassandra-all}} library consumers of the CQLSSTableWriter class cannot > easily create an appropriate instance of the {{LocalDate}} class in order to > write SSTables including dates, and the current implementation no longer > accepts a {{int}} value as a valid input as previous versions of the class > would - we used to use > {{((AbstractType)columnSpecification.type).decompose(value);}} in order to > serialize the value, but now we use the type codec's .serialize method. > Unfortunately, this doesn't work when the consumer can't easily create the > type needed (serialize, in the case of dates, takes a {{LocalDate}} instance > which is not easy to construct outside of Cassandra internal code). > This can be worked around by catching the resulting {{ClassCastException}} > thrown from the {{serialize}} call and falling back to the older > {{decompose}} implementation, which would maintain backwards-compatibility > with other users of the CQLSSTableWriter in cases where they are passing > integers for date fields, which used to work. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org