[ https://issues.apache.org/jira/browse/CASSANDRA-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Berenguer Blasi updated CASSANDRA-17122: ---------------------------------------- Reviewers: Berenguer Blasi Status: Review In Progress (was: Patch Available) > Add utilities for materialized views to CQLTester > ------------------------------------------------- > > Key: CASSANDRA-17122 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17122 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit > Reporter: Andres de la Peña > Assignee: Andres de la Peña > Priority: Normal > Fix For: 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > CASSANDRA-17070 added automatic generation of MV names to all > {{ViewComplex*Test}} based on an incremented {{AtomicInteger}} to prevent > conflicts when the cleanup methods leave a dirty environment. However, we > still have ten MV tests that could benefit from this kind of name generation > to avoid potential name conflicts. > Also, the tests for materialized views have multiple code duplications. There > are three identical implementations of the {{createView(String, String)}} > method, eight lists of created views and six almost identical > parameterizations of {{{}ProtocolVersion{}}}. > I think we should add methods to create and drop MVs to {{{}CQLTester{}}}, > analogous to the methods that it already has for keyspaces, tables, indexes, > functions and aggregates. That way we would prevent potential conflicts with > MV names and reduce code duplication. These methods would also be useful for > any new tests using MVs that we add in the future, such as for example the > ones that we would probably need for any future guardrail on MVs. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org