[
https://issues.apache.org/jira/browse/CASSANDRA-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451441#comment-17451441
]
David Capwell commented on CASSANDRA-17168:
-------------------------------------------
Overall +1 (assuming repair tests are passing). I am not a fan of breaking
change in the protocol, though I do know we say repair isn't supported in
mixed-mode...
> Don't block gossip when clearing snapshots for failing repairs
> --------------------------------------------------------------
>
> Key: CASSANDRA-17168
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17168
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> We clear snapshots in the GossipTasks thread when a repair session fails due
> to a replica shutting down. If there are many tables/repair sessions ongoing
> this can take a long time. With enough tables being repaired at the same time
> even checking if the snapshots exists can take long enough to mark nodes down.
> We should clear snapshots in a separate thread and add a flag to tell us
> whether this repair session can have snapshots to avoid checking if the
> directory exists.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
