[
https://issues.apache.org/jira/browse/CASSANDRA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452666#comment-17452666
]
Andres de la Peña edited comment on CASSANDRA-17147 at 12/3/21, 2:15 AM:
-------------------------------------------------------------------------
[~dcapwell] thanks for the careful review :)
I have just incorporated the last suggestions about those final fields and the
insertion-ordered set.
The PR is rebased and CI is running for
[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1197/workflows/cc92de49-182b-4995-81d9-cf760fd8d2a6]
and
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1197/workflows/6c5a4e15-1520-48ca-92bf-2b970c7060e2]
with upgrade tests and 100 repetitions of the new tests. That's not a very
high number of repetitions but the previous CI runs also included repeated runs
and they weren't very different.
As it's mentioned on the PR, this was initially meant to go into a feature
branch, but we haven't included anything in the framework that isn't used by
the six guardrails that are being added, and these guardrails deliver some
useful new features, so this can go straight into trunk. The rest of the
guardrails and features will be added by the other tickets in the epic
(CASSANDRA-17146).
[~stefan.miklosovic] anything else to add? Are we ready to merge, assuming CI
looks good?
was (Author: adelapena):
[~dcapwell] thanks for the careful review :)
I have just incorporated the last suggestions about those final fields and the
insertion-ordered set.
The PR is rebased and CI is running for
[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1197/workflows/a6c70521-c19e-4d5f-a070-ce1aaace818d]
and
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1197/workflows/6c5a4e15-1520-48ca-92bf-2b970c7060e2]
with upgrade tests and 100 repetitions of the new tests. That's not a very
high number of repetitions but the previous CI runs also included repeated runs
and they weren't very different.
As it's mentioned on the PR, this was initially meant to go into a feature
branch, but we haven't included anything in the framework that isn't used by
the six guardrails that are being added, and these guardrails deliver some
useful new features, so this can go straight into trunk. The rest of the
guardrails and features will be added by the other tickets in the epic
(CASSANDRA-17146).
[~stefan.miklosovic] anything else to add? Are we ready to merge, assuming CI
looks good?
> Guardrails prototype
> --------------------
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
