[ https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457138#comment-17457138 ]
Benjamin Lerer commented on CASSANDRA-17133: -------------------------------------------- I had a look at the code and it seems that the mistake is mine. We did not need to add those new functions in CASSANDRA-17029 as the functionality was already there. We had the following functions: * toDate(timestamp) * toTimestamp(date) * mintimeuuid(timestamp) * maxtimeuuid(timestamp) Those functions were not overloaded so they will be the ones being picked up but the code allow deserialization from integer to the timestampt type or the date type. by consequence adding new function was not needed and in fact lead to a slightly different behavior. What I would suggest it to remove the methods added by CASSANDRA-17029 and modify the tests to verify the behavior with int an long inputs. Sorry for not realizing that sooner. :-( > Broken test_timeuuid - upgrade_tests.cql_tests > ---------------------------------------------- > > Key: CASSANDRA-17133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17133 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics > Reporter: Yifan Cai > Assignee: Kanthi Subramanian > Priority: Normal > Fix For: 4.x > > > Both CircleCI and Jenkins build failed at test_timeuuid with the following > error. > {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query] > message="Ambiguous call to function maxtimeuuid (can be matched by following > signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid : > (timestamp) -> timeuuid): use type casts to disambiguate"{quote} > https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0 > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/ > The change was added in CASSANDRA-17029. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org