[ 
https://issues.apache.org/jira/browse/CASSANDRA-17195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460413#comment-17460413
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17195:
-------------------------------------------------

Thanks [~adelapena] , overall looks good and the logging improvement seems 
reasonable. Thanks!

I left a few small suggestions and questions on the PR.

The CI run look fine. Only that materialized view related test I can't remember 
seeing it failing but I am not sure also it can be related. Probably as a 
minimum we need to open at least a ticket for it. 

> Migrate thresholds for number of keyspaces and tables to guardrails
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-17195
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17195
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Feature/Guardrails
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Migrate the existing thresholds for the number of keyspaces and tables:
> {code}
> # table_count_warn_threshold: 150
> # keyspace_count_warn_threshold: 40
> {code}
> to a new guardrail under the guardrails section, for example:
> {code}
> guardrails:
>     keyspaces:
>         warn_threshold: 40
>         abort_threshold: -1
>     tables:
>         warn_threshold: 150
>         abort_threshold: -1
> {code}
> Please note that CASSANDRA-17147 has already added a guardrail for the number 
> of tables, but the previous not-guardrail threshold for warning about the 
> number of tables still exists.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to