[ 
https://issues.apache.org/jira/browse/CASSANDRA-17205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh McKenzie updated CASSANDRA-17205:
--------------------------------------
    Status: Ready to Commit  (was: Review In Progress)

> File leaks will not be be detected and released due to strong self-references 
> in the tidier
> -------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17205
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17205
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable
>            Reporter: Josh McKenzie
>            Assignee: Josh McKenzie
>            Priority: Normal
>
> LogTransaction.SSTableTidier holds a reference to a {{Tracker}} which holds 
> references to both a {{ColumnFamilyStore}} and a {{View}}, both of which hold 
> refs to SSTableReaders. As per the comment at the top of the SSTableTidier:
> {quote}// must not retain a reference to the SSTableReader, else leak 
> detection cannot kick in
> {quote}
> We shouldn't hold a reference to the Tracker here; long running unit tests 
> w/-Dcassandra.debugrefcount=true had this pop up.
> {code}ERROR [Strong-Reference-Leak-Detector:1] 2020-10-27T01:10:12,421 
> NoSpamLogger.java:97 - Strong self-ref loop detected{code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to