[
https://issues.apache.org/jira/browse/CASSANDRA-17190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470196#comment-17470196
]
Brandon Williams commented on CASSANDRA-17190:
----------------------------------------------
Unfortunately, the failures
([here|https://app.circleci.com/pipelines/github/driftx/cassandra/315/workflows/64b1e141-7948-4a49-9df7-9b9bab42eb63/jobs/2972/tests#failed-test-0],
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/315/workflows/8f0c71a5-e377-400a-a698-94ecb5a83c0e/jobs/2978/tests#failed-test-0])
for the
[test_udf_overload|https://github.com/apache/cassandra-dtest/blob/trunk/user_functions_test.py#L136]
dtest are legitimate and caused by this patch, I manually verified as well.
> Add support for String contatenation through the "+" operator
> -------------------------------------------------------------
>
> Key: CASSANDRA-17190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17190
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Benjamin Lerer
> Assignee: Manish Ghildiyal
> Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.x
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Since 4.0, Cassandra support operations on numeric types and on some temporal
> types.
> We should add support for string concatenations through the {{+}} operator.
> +Additional information for newcomers:+
> Cassandra has 2 string types: {{Text}} ({{UTF8Type}}) and ascii
> ({{AsciiType}}) both are sub-classes of ({{StringType}}). In order to add
> support for string concatenation you will need to add a new method to
> {{StringType}} and modify {{OperationFcts}} to add the new functions (one for
> each combination of types: ascii/ascii, ascii/text, text/ascii and text/text).
> The unit test should be added to {{OperationFctsTest}}.
> To allow for concatenating constants (eg: SELECT v1 + ' ' + v2 FROM ...) you
> will need to add a {{getPreferedTypeFor}} method to
> {{org.apache.cassandra.Constants.Type.STRING}} that determine the constant
> type based on its content (ascii or not).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
