[
https://issues.apache.org/jira/browse/CASSANDRA-17243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474540#comment-17474540
]
Ekaterina Dimitrova edited comment on CASSANDRA-17243 at 1/12/22, 1:53 PM:
---------------------------------------------------------------------------
Oh, indeed you are right it dates earlier than CASSANDRA-16959.
Thinking more about it I am wondering whether it won't change a bit behavior
then and which branches to target for the fix.
Also, pre-4.0 we don't have _SetGetStreamThroughputTest_ which caught for me a
precision issue with CASSANDRA-15234 that _StreamManagerTest_ missed. But I
don't think this will be an issue here as 1000 * 1000 / 8 gives an integer
result. More of a concern to me is the change of the rate limit.
I want to think of it a bit more on my end.
was (Author: e.dimitrova):
Oh, indeed you are right it dates earlier than CASSANDRA-16959.
Thinking more about it I am wondering whether it won't change a bit behavior
then and which branches to target for the fix.
Pre-4.0 we don't have _SetGetStreamThroughputTest_ which caught for me a
precision issue with CASSANDRA-15234 that _StreamManagerTest_ missed.
I want to think of it a bit more on my end.
> Fix BYTES_PER_MEGABIT in StreamManager
> --------------------------------------
>
> Key: CASSANDRA-17243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17243
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
> Reporter: Ekaterina Dimitrova
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> While working on CASSANDRA-15234 I noticed BYTES_PER_MEGABIT constant in the
> {code:java}
> StreamManager
> {code}
> class. It was introduced in CASSANDRA-16959.
> The current formula converts actually bytes to mebibits.
> The change needed for 3.0, 3.11 and 4.0(I am currently changing rate
> parameters to be in MiB/s for trunk as part of CASSANDRA-15234):
> {code:java}
> public static final double BYTES_PER_MEGABIT = (1000 * 1000) / 8; // from bits
> {code}
> CC [~adelapena]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
