[jira] [Commented] (CASSANDRA-17271) Remove unused dependency of geomet from cqlsh.py

[Berenguer Blasi (Jira)]

    [ 
https://issues.apache.org/jira/browse/CASSANDRA-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479142#comment-17479142
 ] 

Berenguer Blasi commented on CASSANDRA-17271:
---------------------------------------------

Reviewed code +1, reasoning lgtm +1 and CI is good as per status quo. +1

> Remove unused dependency of geomet from cqlsh.py
> ------------------------------------------------
>
>                 Key: CASSANDRA-17271
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17271
>             Project: Cassandra
>          Issue Type: Task
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Brad Schoening
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> The python library *geomet* is used (optionally) by a unit test in the python 
> driver, but was made optional in v3.24.0 of the cassandra-driver:
>  * 👉 Make geomet an optional dependency at runtime (PYTHON-1237)
> It's inclusion on the sys.path for cqlsh would appear unnecessary and unused.
>  
> cqlsh.py:
> {quote}third_parties = ('futures-', 'six-', 'geomet-'){quote}
> {quote}for lib in third_parties:
>     lib_zip = find_zip(lib)
>     if lib_zip:
>         sys.path.insert(0, lib_zip){quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org