[ https://issues.apache.org/jira/browse/CASSANDRA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485397#comment-17485397 ]
Yifan Cai edited comment on CASSANDRA-17224 at 2/1/22, 8:44 PM: ---------------------------------------------------------------- Starting commit CI Results: ||Branch||Source||Circle CI|| |trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17224-trunk-406EFD1A-EE56-41B6-B89F-8B8D0BB8F917]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17224-trunk-406EFD1A-EE56-41B6-B89F-8B8D0BB8F917]| CI run looks good with some known flaky tests. None of them are related with the patch. was (Author: yifanc): Starting commit CI Results (pending): ||Branch||Source||Circle CI|| |trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17224-trunk-406EFD1A-EE56-41B6-B89F-8B8D0BB8F917]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17224-trunk-406EFD1A-EE56-41B6-B89F-8B8D0BB8F917]| > Add a virtual table for exposing prepared statements metrics > ------------------------------------------------------------ > > Key: CASSANDRA-17224 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17224 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Virtual Tables, Observability/Metrics > Reporter: Benjamin Lerer > Assignee: Shailaja Koppu > Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 4.x > > Time Spent: 10.5h > Remaining Estimate: 0h > > There are some existing metrics within {{CQLMetrics}} that provide metrics > about prepared statements. We should expose those through a virtual table. > +Additional information for newcomers:+ > A new class should be created for representing the new Virtual Table in > {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for > an example. > The new table will need to be registered in {{SystemViewsKeyspace}}. > Some unit tests will need to be added. For some example of virtual table > tests you can look at {{SystemPropertiesTableTest}} and for some example of > test around prepared statement metrics you can look into {{CQLMetricsTest}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org