[ https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486368#comment-17486368 ]
Stefan Miklosovic edited comment on CASSANDRA-16956 at 2/3/22, 10:44 AM: ------------------------------------------------------------------------- * yeah I ll do that * it is already in NEWS.txt here (1), I dont find any added value in repeating that information. * Yes, removed * I have grepped the docs and I have fixed it where Windows is mentioned. There is also mention about Docker on Windows, I kept it there. * I fixed few comments explicitly mentioning that Windows was dropped. As a side-effect of dropping the Windows support completely, I would like to dedicate yet another ticket for resolving this "issue" (2). Basically, we are not limited to having file names of some pre-defined max length. However I consider this to be outside of the scope and it can be treated in a separate ticket in the future, not going too deep into the rabbit hole for now. I am not sure what other consequencies it might have to suddently not be limited on file name lenghts in that particular case. (1) https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L397-L401 (2) https://github.com/instaclustr/cassandra/blob/CASSANDRA-16956/src/java/org/apache/cassandra/schema/SchemaConstants.java#L56-L62 Branch: https://github.com/apache/cassandra/compare/trunk...instaclustr:CASSANDRA-16956 PR: https://github.com/apache/cassandra/pull/1249 I ll provide build soonish, hopefully. We got some problems in Circle so trying my luck in Jenkins. was (Author: smiklosovic): * yeah I ll do that * it is already in NEWS.txt here (1), I dont find any added value in repeating that information. * Yes, removed * I have grepped the docs and I have fixed it where Windows is mentioned. There is also mention about Docker on Windows, I kept it there. * I fixed few comments explicitly mentioning that Windows was dropped. As a side-effect of dropping the Windows support completely, I would like to dedicate yet another ticket for resolving this "issue" (2). Basically, we are not limited to having file names of some pre-defined max length. However I consider this to be outside of the scope and it can be treated in a separate ticket in the future, not going too deep into the rabbit hole for now. I am not sure what other consequencies it might have to suddently not be limited on file name lenghts in that particular case. (1) https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L397-L401 (2) https://github.com/instaclustr/cassandra/blob/CASSANDRA-16956/src/java/org/apache/cassandra/schema/SchemaConstants.java#L56-L62 Branch: https://github.com/apache/cassandra/compare/trunk...instaclustr:CASSANDRA-16956 I ll provide build soonish, hopefully. We got some problems in Circle so trying my luck in Jenkins. > Remove windows-specific classes > ------------------------------- > > Key: CASSANDRA-16956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16956 > Project: Cassandra > Issue Type: Task > Components: Build > Reporter: Brandon Williams > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: signature.asc, signature.asc, signature.asc, > signature.asc, signature.asc, signature.asc, signature.asc, signature.asc > > > To continue the work CASSANDRA-16171 began, now that Windows support is no > more there are some source files that can be removed. > Just doing a naive grep on the source directory I see: > {noformat} > src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java > src/java/org/apache/cassandra/utils/NativeLibraryWindows.java > src/java/org/apache/cassandra/utils/WindowsTimer.java > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org