[
https://issues.apache.org/jira/browse/CASSANDRA-17078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488275#comment-17488275
]
Josh McKenzie edited comment on CASSANDRA-17078 at 2/7/22, 5:20 PM:
--------------------------------------------------------------------
{quote}Should we backport them to 4.0 and 3.x branches?
{quote}
I'll take a look; if the tests isn't flaking out there I'd say we hold off and
I'll just keep an eye on it and backport if it starts to misbehave later. edit:
shows up on 4.0. I'll target 4.0.x and 4.x with this.
{quote}You missed removing store.discardSSTables(System.currentTimeMillis());
in testGetPositionsForRanges
{quote}
Good catch.
was (Author: jmckenzie):
bq. Should we backport them to 4.0 and 3.x branches?
I'll take a look; if the tests isn't flaking out there I'd say we hold off and
I'll just keep an eye on it and backport if it starts to misbehave later.
bq. You missed removing store.discardSSTables(System.currentTimeMillis()); in
testGetPositionsForRanges
Good catch.
> Fix failing test: SSTableReaderTest.testPersistentStatistics
> ------------------------------------------------------------
>
> Key: CASSANDRA-17078
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17078
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Fix For: 4.x
>
>
> JDK8 unit test failure
> See it on CircleCI but not on Jenkins ASF infra right now.
> {code:java}
> java.lang.RuntimeException: Failed importing sstables
> at
> org.apache.cassandra.db.SSTableImporter.importNewSSTables(SSTableImporter.java:164)
> at
> org.apache.cassandra.db.ColumnFamilyStore.loadNewSSTables(ColumnFamilyStore.java:734)
> at
> org.apache.cassandra.io.sstable.SSTableReaderTest.clearAndLoad(SSTableReaderTest.java:222)
> at
> org.apache.cassandra.io.sstable.SSTableReaderTest.testPersistentStatistics(SSTableReaderTest.java:215)
> Caused by: java.lang.RuntimeException: Failed to rename
> /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-9-big-Digest.crc32
> to
> /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-13-big-Digest.crc32
> at org.apache.cassandra.io.util.PathUtils.rename(PathUtils.java:385)
> at org.apache.cassandra.io.util.File.move(File.java:227)
> at
> org.apache.cassandra.io.util.FileUtils.renameWithConfirm(FileUtils.java:704)
> at
> org.apache.cassandra.io.util.FileUtils.renameWithConfirm(FileUtils.java:698)
> at
> org.apache.cassandra.io.sstable.format.SSTableWriter.rename(SSTableWriter.java:337)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.moveAndOpenSSTable(SSTableReader.java:2339)
> at
> org.apache.cassandra.db.SSTableImporter.importNewSSTables(SSTableImporter.java:139)
> Caused by: java.nio.file.NoSuchFileException:
> /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-9-big-Digest.crc32
> ->
> /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-13-big-Digest.crc32
> at
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
> at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
> at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:396)
> at
> sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262)
> at java.nio.file.Files.move(Files.java:1395)
> at
> org.apache.cassandra.io.util.PathUtils.atomicMoveWithFallback(PathUtils.java:396)
> at org.apache.cassandra.io.util.PathUtils.rename(PathUtils.java:377)
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
