[
https://issues.apache.org/jira/browse/CASSANDRA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066704#comment-13066704
]
Nick Bailey commented on CASSANDRA-2805:
----------------------------------------
I'm not sure you need to add any constructors to Range. How about just an
asPair() method or something similar that returns the tokens that make up the
range converted to strings?
Everything else looks fine. getRangeToAddressMap() isn't needed because
getRangeToEndpointMap() is exposed.
Another thing that might be nice to fix here is the getNaturalEndpoints()
method. It currently only takes a byte array or byteBuffer object which makes
it impossible to call from something like jconsole. It would be nice to
overload that with another method that takes a string as the key so you can
call it from jconsole.
> Clean up mbeans that return Internal Cassandra types
> ----------------------------------------------------
>
> Key: CASSANDRA-2805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2805
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.1
> Reporter: Nick Bailey
> Assignee: Gaurav Sharma
> Priority: Minor
> Labels: lhf
> Fix For: 0.8.2
>
>
> We need to clean up wherever we return internal cassandra objects over jmx.
> Namely CompactionInfo objects as well as Tokens. There may be a few other
> examples.
> This is bad for two reasons
> 1. You have to load the cassandra jar when querying these mbeans, which sucks.
> 2. Stuff breaks between versions when things are moved. For example,
> CASSANDRA-1610 moves the compaction related classes around. Any code querying
> those jmx mbeans in 0.8.0 is now broken in 0.8.2. (assuming those moves stay
> in the 0.8 branch)
> For things like CompactionInfo we should just expose more mbean methods or
> serialize to something standard like json.
> I'd like to target this for 0.8.2. Since we've already broken compatibility
> between 0.8.0 and 0.8.1, I'd say just fix this everywhere now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
