[ https://issues.apache.org/jira/browse/CASSANDRA-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495208#comment-17495208 ]
Andres de la Peña commented on CASSANDRA-17153: ----------------------------------------------- It seems there is a mistake on [{{Guardrails#enable(ClientState)}}|https://github.com/apache/cassandra/blob/db3583318258b14b27abe1529f8893da2ff22bf5/src/java/org/apache/cassandra/db/guardrails/Guardrails.java#L150] where this method tries to get the config before checking that the deamon is initialized. This was producing failures on offline scrub tests due to the new call to that method from \{{SSTableWriter}} introduced by this patch. I have just fixed it on the PR: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/1459]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1309/workflows/0c61403a-edd2-4d0d-b4fe-34c1060fd639] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1309/workflows/a0c7ede8-8347-4d27-b080-19a571f1a160]| > Guardrails for collection items and size > ---------------------------------------- > > Key: CASSANDRA-17153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17153 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails > Reporter: Andres de la Peña > Assignee: Andres de la Peña > Priority: Normal > Fix For: 4.x > > > Add guardrails for the number of items and size of collections. For example: > {code} > # Guardrail to warn or fail when encountering larger size of collection data > than threshold. > # The two thresholds default to 0KiB to disable. > collection_size_warn_threshold: 0KiB > collection_size_fail_threshold: 0KiB > # Guardrail to warn or fail when encountering more elements in collection > than threshold. > # The two thresholds default to -1 to disable. > items_per_collection_warn_threshold: -1 > items_per_collection_fail_threshold: -1 > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org