[
https://issues.apache.org/jira/browse/CASSANDRA-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499506#comment-17499506
]
Jan Karlsson edited comment on CASSANDRA-17407 at 3/1/22, 12:38 PM:
--------------------------------------------------------------------
You might have a point about this feeling more like a bug than an improvement.
It certainly is confusing behavior for users.
I was thinking something like this for the patch:
||Patch||Test||
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...itskarlsson:c17407-3.11?expand=1]|[CircleCi|https://app.circleci.com/pipelines/github/itskarlsson/cassandra/9/workflows/ca527be8-4145-4c55-bfb4-7cec670e7b4c]|
The patch applies cleanly to 4.0/trunk. I can provide patches for the other
versions too if needed.
was (Author: jan karlsson):
You might have a point about this feeling more like a bug than an improvement.
It certainly is confusing behavior for users.
I was thinking something like this for the patch:
||Patch||Test||
|[3.11\|https://github.com/apache/cassandra/compare/cassandra-3.11...itskarlsson:c17407-3.11?expand=1]|[CircleCi\|https://app.circleci.com/pipelines/github/itskarlsson/cassandra/9/workflows/ca527be8-4145-4c55-bfb4-7cec670e7b4c]|
The patch applies cleanly to 4.0/trunk. I can provide patches for the other
versions too if needed.
> Validate existence of DCs when repairing
> ----------------------------------------
>
> Key: CASSANDRA-17407
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17407
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
> Reporter: Jan Karlsson
> Assignee: Jan Karlsson
> Priority: Normal
> Fix For: 3.11.x, 4.0.x
>
>
> With the new validation of data centers in the replication factor, it might
> be good to give similar treatment to repair.
> Currently the behavior of the --in-dc flag only validates that it contains
> the local data center.
> If a list is given containing nonexistent data centers, the repair will pass
> without errors or warning as long as this list also contains the local data
> center.
> My suggestion would be to validate all the data centers and give an error
> when a nonexistent data center is given.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
