[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508013#comment-17508013
]
Jogesh Anand edited comment on CASSANDRA-16916 at 3/17/22, 7:51 AM:
--------------------------------------------------------------------
[~e.dimitrova] - thank you so much for the guidance on this ticket and tagging
relevant folks. Appreciate it. Thanks for pushing Jenkins build. If I could get
limited access to Jenkins, such as, can only run once a day, that would be huge
for newcomers/budding enthusiasts. I did try CircleCI but..
Thanks [~bereng] for taking time to review. Glad that Jenkins looks good
(1) Did a rebase and can see the previous SHAs from git log. Did not squash
commits this time. (2) addressed and updated review comments, when you get
sometime. (3) added entry in CHANGES.txt with the assumption that the change
would be part of 4.1 release. (4) Could you let me know how and where can I
update docs for this ?
was (Author: djanand):
[~e.dimitrova] - thank you so much for the guidance on this ticket and tagging
relevant folks. Appreciate it. Thanks for pushing Jenkins build. If I could get
limited access to Jenkins, such as, can only run once a day, that would be huge
for newcomers/budding enthusiasts. I did try CircleCI but..
Thanks [~bereng] for taking time to review. Glad that Jenkins looks good
(1) Did a rebase and can see the previous SHAs from git log. Did not squash
commits this time. (2) addressed and updated review comments, when you get
sometime. (3) add entry in CHANGES.txt with the assumption that the change
would be part of 4.1 release. (4) Could you let me know how and where can I
update docs for ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---------------------------------------------------------------
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
> Reporter: Benjamin Lerer
> Assignee: Jogesh Anand
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
