[ https://issues.apache.org/jira/browse/CASSANDRA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510518#comment-17510518 ]
Josh McKenzie commented on CASSANDRA-17017: ------------------------------------------- {quote} - CI is failing sstableverify{quote} I mentioned that this is a known issue and works w/the correct dtest branch locally {quote} - Some of your non circle commits change circle files. Be careful as that sounds like an accident waiting to happen on merge?{quote} I have a "fully revert all .circleci changes pre commit" step in my personal workflow that should take care of this; I was one-off attempting to get the thing to respect my custom DTEST_REPO changes. Didn't realize I had to change it in 34 different places. {quote} - I see some unrelated changes to CHANGES.txt i.e. Do you need to rebase maybe?{quote} Just needed a rebase. Done. I'll update the docs and give the custom dtest in circle testing one more shot in a few. > Add required -f / --force option to nodetool verify > --------------------------------------------------- > > Key: CASSANDRA-17017 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17017 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool > Reporter: Josh McKenzie > Assignee: Josh McKenzie > Priority: Normal > Fix For: 4.1 > > > nodetool verify has some pretty significant problems with it (see > CASSANDRA-9947). > Until such time as we do the heavy(er) lift to fix the command, we should > make it harder for people to shoot themselves in the foot with it. Adding a > required "-f" flag to it with a requisite "Do you really know what you're > doing? Check out this JIRA first" seems like it'd be the right thing to do in > the interim. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org