[
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521339#comment-17521339
]
Ekaterina Dimitrova commented on CASSANDRA-17532:
-------------------------------------------------
{code:java}
The problem we face is that InstanceConfig on trunk gets configs added that
make sense on trunk but not older versions;
{code}
This problem is with all versions, not only trunk. We have new config added to
every major version which doesn't exist in older versions.
{code:java}
I feel this patch doesn't solve the intent, making our tests safer by checking;
as the tests still don't check they are just more verbose.
{code}
Valid point, it was never its intention to solve this limitation, same as the
flag when it was introduced. The reason why I suggested to flip the flag was to
make it verbose to people so they know this flag exists and they check their
config intentionally before setting in a new test until that limitation is
solved.
Otherwise, currently we never check the config by default, most of the people
don't know about the flag and don't check it also manually carefully as they
would expect Cassandra to complain as usual. I documented this behavior on the
config page, but I am not sure how many people will read it at all. So at least
until this is solved people can get an exception for new config and
intentionally check what they set on their own instead of silently config being
ignored and tests passing. Considering a new test is added once in a few
months, it is not a big burden until the limitation is worked out, probably
after the release.
> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade
> tests
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We reached lazy consensus on this here:
> [https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
