[
https://issues.apache.org/jira/browse/CASSANDRA-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521969#comment-17521969
]
Caleb Rackliffe commented on CASSANDRA-17034:
---------------------------------------------
Done with my first pass at review. I've left a ton of nits and questions inline
in the PR. Aside from what I mentioned above in my previous comment, the only
thing I'm really worried about in terms of the impact on 4.1 is
[this|https://github.com/apache/cassandra/pull/1295/files#r848687665]. Overall,
things look pretty good, and the copious inline documentation made most things
easy to reason about.
I've gone back and forth mentally about the depth of the hierarchy under
{{Memtable}}, specifically whether composition would have made sense (i.e.
having strategies for allocation, commitlog stuff, etc.). Perhaps the fact that
either we'll control these implementations pretty tightly or there won't be too
many external ones makes this unimportant. (I'll also ignore for the moment the
divergence this might create for public/non-public forks, lol)
> CEP-11: Memtable API implementation
> -----------------------------------
>
> Key: CASSANDRA-17034
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17034
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Memtable
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
> Priority: Normal
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> Pluggable memtable API as described in
> [CEP-11|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-11%3A+Pluggable+memtable+implementations].
>
> Initial version is already available in [this
> branch|https://github.com/datastax/cassandra/tree/memtable-api], and needs to
> be updated to the changes in trunk. Two additional features suggested by CEP
> reviewers are also to be implemented:
> * Sharding support: extending the memtable owner interface to supply
> suitable shard boundaries that split the owned token space and are in
> agreement with disk boundaries.
> * Shared read API with sstables: defining a common interface for reading
> partitions from memtables and sstables; this is to include filters to avoid
> unnecessary copying.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
