[ https://issues.apache.org/jira/browse/CASSANDRA-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522953#comment-17522953 ]
Ekaterina Dimitrova commented on CASSANDRA-17150: ------------------------------------------------- Solid patch as usual, it just took me some time to wrap up my mind as I see this work first time. I left small questions&comments. I am thinking it is good to verify with [~jasonstack] the new approach you took in regards to the calculations. Maybe it was considered during the initial discussions and he has something to add? Or maybe it's just me making noise. :) 1 thing I noticed is we will hit warnings faster. Probably it is more accurate but I am also wondering about recommendations for users in order not to corner themselves. We need also NEWS.txt entry. > Guardrails for disk usage > ------------------------- > > Key: CASSANDRA-17150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17150 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails > Reporter: Andres de la Peña > Assignee: Andres de la Peña > Priority: Normal > Fix For: 4.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > Add guardrails for disk usage establishing soft/hard limits on the percentage > of used disk space. For example: > {code} > # Warning threshold to warn when local disk usage exceeds threshold. Valid > values: (1, 100] > # Defaults to -1 to disable. > # disk_usage_percentage_warn_threshold: -1 > # Failure threshold to reject write requests if replica disk usage exceeds > threshold. Valid values: (1, 100] > # Defaults to -1 to disable. > # disk_usage_percentage_failure_threshold: -1 > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org