[ https://issues.apache.org/jira/browse/CASSANDRA-17551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523910#comment-17523910 ]
Ekaterina Dimitrova commented on CASSANDRA-17551: ------------------------------------------------- Disable guardrail by using null was already handled by [~adelapena] in CASSANDRA-17150. Though 0 is prohibited value there. So we need to take care of 0, wondering whether to allow it for disable collections or to create a new guardrail for that. [~adelapena] what do you think? > 0KiB should be used to prohibit collections and not to disable the guardrails > collection_size_warn_threshold and collection_size_fail_threshold > ----------------------------------------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-17551 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17551 > Project: Cassandra > Issue Type: Bug > Components: Feature/Guardrails > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.x > > > # The two thresholds default to 0KiB to disable. > # collection_size_warn_threshold: 0KiB > # collection_size_fail_threshold: 0KiB > 0KiB should be used to prohibit collections and not to disable the guardrail. > Disabled should be null as we moved to that as part of CASSANDRA-17431 while > investigating other config corner cases. > Old config which had -1 for disable will be converted internally to null with > the new config types and new config should use null for disable. Of course, > disabling 0 as a non-valid value is a different story which should be handled > on per-case basis. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org