[ https://issues.apache.org/jira/browse/CASSANDRA-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067556#comment-13067556 ]
David Allsopp edited comment on CASSANDRA-2850 at 7/23/11 10:15 PM: -------------------------------------------------------------------- Something funny going on with the versions? - the revision numbers in your patch seem way higher than the ones I can see in SVN for trunk or 0.8 or 0.8.1 branches. I don't see the unit test failures here. -However, I _think_ one bug may be using bytes.get(i) rather than bytes.get(i) & 0xff as in the older code, to treat values as unsigned. Will take another look tonight.- was (Author: dallsopp): Something funny going on with the versions? - the revision numbers in your patch seem way higher than the ones I can see in SVN for trunk or 0.8 or 0.8.1 branches. I don't see the unit test failures here. However, I _think_ one bug may be using bytes.get(i) rather than bytes.get(i) & 0xff as in the older code, to treat values as unsigned. Will take another look tonight. > Converting bytes to hex string is unnecessarily slow > ---------------------------------------------------- > > Key: CASSANDRA-2850 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2850 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: David Allsopp > Assignee: David Allsopp > Priority: Minor > Fix For: 0.8.3 > > Attachments: 2850-rebased.txt, 2850-v2.patch, 2850-v4.patch, > 2850-v4a.patch, BytesToHexBenchmark.java, BytesToHexBenchmark2.java, > BytesToHexBenchmark3.java, cassandra-2850a.diff > > > ByteBufferUtil.bytesToHex() is unnecessarily slow - it doesn't pre-size the > StringBuilder (so several re-sizes will be needed behind the scenes) and it > makes quite a few method calls per byte. > (OK, this may be a premature optimisation, but I couldn't resist, and it's a > small change) > Will attach patch shortly that speeds it up by about x3, plus benchmarking > test. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira