[
https://issues.apache.org/jira/browse/CASSANDRA-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526317#comment-17526317
]
Andres de la Peña edited comment on CASSANDRA-17150 at 4/22/22 2:05 PM:
------------------------------------------------------------------------
[~e.dimitrova] thanks for the review. I think I have addressed the last bits.
I'm running CI after rebase+squash:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1546]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1494/workflows/d032178d-f8a9-4124-b36f-5bf6f47b3116]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1494/workflows/bc844580-6f3a-4bc3-a4d0-d85f082330f8]|
Please note that during the rebase I have replaced a few references to the
removed {{Config.DISABLED_GUARDRAIL}} constant by {{-1}}. Those references were
recently added to track warnings during CASSANDRA-17560. As it's mentioned
[here|https://github.com/apache/cassandra/pull/1572#discussion_r854251196],
using {{-1}} as the disabled value is a global config convention and not a
guardrails thing, so we should either use it directly or define a new constant
with a more generic name. If we decide to do the latter, I'd prefer to do it in
a separate ticket, so we can focus on locating all the usages around.
was (Author: adelapena):
[~e.dimitrova] thanks for the review. I think I have addressed the last bits.
I'm running CI after rebase+squash:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1546]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1494/workflows/d032178d-f8a9-4124-b36f-5bf6f47b3116]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1494/workflows/bc844580-6f3a-4bc3-a4d0-d85f082330f8]|
Please note that during the rebase I have replaced a few references to the
removed `Config.DISABLED_GUARDRAIL` constant by {{{}-1{}}}. Those references
were recently added to track warnings during CASSANDRA-17560. As it's mentioned
[here|https://github.com/apache/cassandra/pull/1572#discussion_r854251196],
using {{-1}} as the disabled value is a global config convention and not a
guardrails thing, so we should either use it directly or define a new constant
with a more generic name. If we decide to do the latter, I'd prefer to do it in
a separate ticket, so we can focus on locating all the usages around.
> Guardrails for disk usage
> -------------------------
>
> Key: CASSANDRA-17150
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17150
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Add guardrails for disk usage establishing soft/hard limits on the percentage
> of used disk space. For example:
> {code}
> # Warning threshold to warn when local disk usage exceeds threshold. Valid
> values: (1, 100]
> # Defaults to -1 to disable.
> # disk_usage_percentage_warn_threshold: -1
> # Failure threshold to reject write requests if replica disk usage exceeds
> threshold. Valid values: (1, 100]
> # Defaults to -1 to disable.
> # disk_usage_percentage_failure_threshold: -1
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
