[ 
https://issues.apache.org/jira/browse/CASSANDRA-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529505#comment-17529505
 ] 

David Capwell commented on CASSANDRA-17563:
-------------------------------------------

bq. Is this change (dropping simulator tests from all test enumeration, 
assuming I'm understanding this correctly) intentional?

[~jmckenzie] they were removed in the vnode patch, I spoke with [~benedict] and 
the patch manually modified the config.yml* files and not config-2.1.yml due to 
confusion; the simulator tests were not added at the time so that statement was 
a no-op

Do, it wasn't intentional as it was done by running "generate.sh -a"; I feel 
this should be fixed in a patch to enable simulator tests, I don't see the 
benefit to have it as its dead code atm.

bq. If David Capwell doesn't have the time, I suggest again I do at least the 
fix as this config is really important. 

I have 0 issue taking the patch from this and making its own commit, but I do 
have concerns for me to manually create a new MIDRES as that thing I found out 
the hard way is brittle; hence this patch.  If you are confident I am ok with 
you fixing the patch, but I am not confident about doing it myself.

> Fix CircleCI Midres config
> --------------------------
>
>                 Key: CASSANDRA-17563
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17563
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.1
>
>
> During CircleCI addition of a new job to the config, the midres file got 
> messy. Two of the immediate issues (but we need to verify all jobs will use 
> the right executors and resources):
>  * the new job needs to use higher parallelism as the original in-jvm job
>  *  j8_dtests_with_vnodes should get from midres 50 large but currently 
> midres makes it run with 25 and medium which fails around 100 tests



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to