[ 
https://issues.apache.org/jira/browse/CASSANDRA-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531432#comment-17531432
 ] 

David Capwell commented on CASSANDRA-17595:
-------------------------------------------

Starting commit

CI Results (pending):
||Branch||Source||Circle CI||Jenkins||
|cassandra-4.1|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-17595-cassandra-4.1-0099BC8C-594E-4D5C-A02A-7AC27EBCEC4C]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-17595-cassandra-4.1-0099BC8C-594E-4D5C-A02A-7AC27EBCEC4C]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1655/]|
|trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-17595-trunk-0099BC8C-594E-4D5C-A02A-7AC27EBCEC4C]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-17595-trunk-0099BC8C-594E-4D5C-A02A-7AC27EBCEC4C]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1656/]|


> nodetool enablefullquerylog can NPE when directory has no files
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-17595
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17595
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/fql
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.1.x
>
>
> fqltool_test.py::TestFQLTool::test_unclean_enable found an issue with 
> org.apache.cassandra.utils.binlog.BinLog#deleteRecursively, it assumes 
> listing files returns empty list rather than null and throws a NPE
> {code}
> E           -- StackTrace --
> E           java.lang.NullPointerException
> E             at 
> org.apache.cassandra.utils.binlog.BinLog.deleteRecursively(BinLog.java:490)
> E             at 
> org.apache.cassandra.utils.binlog.BinLog.cleanDirectory(BinLog.java:477)
> E             at 
> org.apache.cassandra.utils.binlog.BinLog$Builder.build(BinLog.java:436)
> E             at 
> org.apache.cassandra.fql.FullQueryLogger.enable(FullQueryLogger.java:106)
> E             at 
> org.apache.cassandra.service.StorageService.enableFullQueryLogger(StorageService.java:6495)
> E             at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> E             at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> E             at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> E             at java.lang.reflect.Method.invoke(Method.java:498)
> E             at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> E             at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> E             at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> E             at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> E             at java.lang.reflect.Method.invoke(Method.java:498)
> E             at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
> E             at 
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
> E             at 
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
> E             at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
> E             at 
> com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
> E             at 
> com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
> E             at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
> E             at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
> E             at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
> E             at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
> E             at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
> E             at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
> E             at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to