[
https://issues.apache.org/jira/browse/CASSANDRA-17647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542409#comment-17542409
]
Aleksey Yeschenko edited comment on CASSANDRA-17647 at 5/26/22 3:38 PM:
------------------------------------------------------------------------
LGTM with just one point to agree on first, CC here from GH for visibility in
case someone has an opinion but isn't following GH:
So, the {{CREATE}} case is pretty obvious. With {{ALTER}}, however, I wonder -
should we allow altering the replication factor on a table that has had
{{SimpleStrategy}} enabled prior to its prohibition by guardrails?
In other words, if current strategy is {{SimpleStrategy}} should we still allow
such an alter? Some system keyspaces are created with {{SimpleStrategy}} - and
are expected to be RF-changed by the user to a cluster-size appropriate RF.
Should we allow upping it if the guardrail is on - while keeping it on
{{SimpleStrategy}}?
I'm leaning towards interpreting the guardrail on as "don't allow {{ALTER}} to
_switch_ to {{SimpleStrategy}}", myself. WDYT?
was (Author: iamaleksey):
LGTM with just one point to agree on first, CC here from GH for visibility in
case someone has an opinion but isn't following GH:
So, the {{{{{}CREATE}}{}}} case is pretty obvious. With {{{{{}ALTER}}{}}},
however, I wonder - should we allow altering the replication factor on a table
that has had {{{{{}SimpleStrategy}}{}}} enabled prior to its prohibition by
guardrails?
In other words, if current strategy is {{{{{}SimpleStrategy}}{}}} should we
still allow such an alter? Some system keyspaces are created with
{{{{{}SimpleStrategy}}{}}} - and are expected to be RF-changed by the user to a
cluster-size appropriate RF. Should we allow upping it if the guardrail is on -
while keeping it on {{{{{}SimpleStrategy}}{}}}?
I'm leaning towards interpreting the guardrail on as "don't allow
{{{{{}ALTER}}{}}} to _switch_ to {{{{{}SimpleStrategy}}{}}}", myself. WDYT?
> Add guardrail to disallow usage of SimpleStrategy
> -------------------------------------------------
>
> Key: CASSANDRA-17647
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17647
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Fix For: 4.x
>
>
> It would be useful for operators to be able to disallow the usage of
> SImpleStrategy accidentally by their users.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
