[ https://issues.apache.org/jira/browse/CASSANDRA-17616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542689#comment-17542689 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17616 at 5/26/22 9:55 PM: -------------------------------------------------------------------------- The changes look correct, I also tested again patches and applying midres, highres. As we weren't adding jobs as the previous time when the config got messed up, the patches apply fine now with these type of changes where we add only a parameter. I double-checked that no other changes than the expected ones have been applied. 4.1 and trunk should be the same so I tested only trunk with the assumption the patch is the same. I also went through the artifacts of the posted runs to verify that the config was really as per expectations. The last 4.1 and trunk didn't have defined repeated upgrade test to run, that's why there are no results there for those. Otherwise things look fine to me. +1, thank you! was (Author: e.dimitrova): The changes look correct, I also tested again patches and applying midres, highres. As we weren't adding jobs as the previous time when the config got messed up, the patches apply fine now. I double-checked that no other changes than the expected ones have been applied. 4.1 and trunk should be the same so I tested only trunk with the assumption the patch is the same. I also went through the artifacts of the posted runs to verify that the config was really as per expectations. The last 4.1 and trunk didn't have defined repeated upgrade test to run, that's why there are no results there for those. Otherwise things look fine to me. +1, thank you! > Add in Circle CI an option to run in a loop tests for the new > j8_jvm_dtests_vnode job > -------------------------------------------------------------------------------------- > > Key: CASSANDRA-17616 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17616 > Project: Cassandra > Issue Type: Task > Components: CI > Reporter: Ekaterina Dimitrova > Assignee: Andres de la Peña > Priority: Normal > Fix For: 4.1-beta, 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the python dtests we need to be able to run in a loop with/without > vnodes the in-jvm tests. Very convenient during debugging flaky tests -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org