[ 
https://issues.apache.org/jira/browse/CASSANDRA-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543048#comment-17543048
 ] 

Paulo Motta commented on CASSANDRA-17619:
-----------------------------------------

bq. I ve changed some tests as well, made it more solid, they were flaky a bit, 
i saw a circle which failed, I will wrap it following days, just busy.

Thanks for the heads up. Can you give more details on what tests were flaky and 
why?

It may be worth to multiplex the snapshot test suites to verify they're not 
flaky before committing.

> Expired snapshots of dropped tables are not removed after node restart
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-17619
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17619
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Snapshots
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>            Priority: Normal
>             Fix For: 4.1-beta
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Expired TTL snapshots from a dropped table are only removed if the node is 
> not restarted after the table is dropped.
> The reason for this is because {{SnapshotManager}} is using the old 
> implementation of {{listsnapshots}} to load snapshots in memory during node 
> startup, before CASSANDRA-16843 is fixed so it doesn't keep track of 
> snapshots of dropped tables.
> We should make {{SnapshotManager}} use the new implementation to load 
> snapshots of dropped tables in memory, what ensures they will be removed when 
> expired.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to