[
https://issues.apache.org/jira/browse/CASSANDRA-17687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554006#comment-17554006
]
Stefan Miklosovic edited comment on CASSANDRA-17687 at 6/14/22 9:25 AM:
------------------------------------------------------------------------
The codebase as such is not buildable with Java 17, what is this patch good for
when we can not build the sources with 17 yet?
I understand it like "we are ready once we are on 17", correct me if I am wrong
here. I am wondering how you managed to verify it renders it correctly on 17
when we can not build it yet.
ant -Duse.jdk11=true javadoc gives
{code:java}
[javadoc] Constructing Javadoc information...
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:30:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.AbstractJSObject;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:31:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.ClassFilter;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:32:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.NashornScriptEngine;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:33:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.NashornScriptEngineFactory;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:108:
error: cannot find symbol
[javadoc] private static final ClassFilter classFilter = clsName ->
secureResource(clsName.replace('.', '/') + ".class");
[javadoc] ^
[javadoc] symbol: class ClassFilter
[javadoc] location: class ScriptBasedUDFunction
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:110:
error: cannot find symbol
[javadoc] private static final NashornScriptEngine scriptEngine;
[javadoc] ^
[javadoc] symbol: class NashornScriptEngine
[javadoc] location: class ScriptBasedUDFunction
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:283:
error: cannot find symbol
[javadoc] private final class UDFContextWrapper extends AbstractJSObject
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:285:
error: cannot find symbol
[javadoc] private final AbstractJSObject fRetUDT;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:286:
error: cannot find symbol
[javadoc] private final AbstractJSObject fArgUDT;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:287:
error: cannot find symbol
[javadoc] private final AbstractJSObject fRetTup;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:288:
error: cannot find symbol
[javadoc] private final AbstractJSObject fArgTup;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc] 11 errors
{code}
was (Author: smiklosovic):
The codebase as such is not buildable with Java 17, what is this patch good for
when we can not build the sources with 17 yet?
I understand it like "we are ready once we are on 17", correct me if I am wrong
here. I am wondering how you managed to verify it renderes it correctly on 17
when we can not build it yet.
ant -Duse.jdk11=true javadoc gives
{code:java}
[javadoc] Constructing Javadoc information...
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:30:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.AbstractJSObject;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:31:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.ClassFilter;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:32:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.NashornScriptEngine;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:33:
error: package jdk.nashorn.api.scripting does not exist
[javadoc] import jdk.nashorn.api.scripting.NashornScriptEngineFactory;
[javadoc] ^
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:108:
error: cannot find symbol
[javadoc] private static final ClassFilter classFilter = clsName ->
secureResource(clsName.replace('.', '/') + ".class");
[javadoc] ^
[javadoc] symbol: class ClassFilter
[javadoc] location: class ScriptBasedUDFunction
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:110:
error: cannot find symbol
[javadoc] private static final NashornScriptEngine scriptEngine;
[javadoc] ^
[javadoc] symbol: class NashornScriptEngine
[javadoc] location: class ScriptBasedUDFunction
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:283:
error: cannot find symbol
[javadoc] private final class UDFContextWrapper extends AbstractJSObject
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:285:
error: cannot find symbol
[javadoc] private final AbstractJSObject fRetUDT;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:286:
error: cannot find symbol
[javadoc] private final AbstractJSObject fArgUDT;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:287:
error: cannot find symbol
[javadoc] private final AbstractJSObject fRetTup;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc]
/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java:288:
error: cannot find symbol
[javadoc] private final AbstractJSObject fArgTup;
[javadoc] ^
[javadoc] symbol: class AbstractJSObject
[javadoc] location: class ScriptBasedUDFunction.UDFContextWrapper
[javadoc] 11 errors
{code}
> Remove "--frames" option when generating javadoc
> ------------------------------------------------
>
> Key: CASSANDRA-17687
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17687
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Normal
> Fix For: 4.x
>
>
> JDK17 doesn't support this option and it seems not quite necessary. For
> forward compatibility I propose we can remove this option.
> Related JDK issue: [https://bugs.openjdk.org/browse/JDK-8215599]
> I volunteer to prepare a patch if this is in a good direction.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
