[ https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555617#comment-17555617 ]
Stefan Miklosovic edited comment on CASSANDRA-16911 at 6/18/22 6:23 PM: ------------------------------------------------------------------------ Hi [~paulo] I would really appreciate your review here [https://github.com/apache/cassandra/pull/1184/files] https://ci-cassandra.apache.org/job/Cassandra-devbranch/1801 was (Author: smiklosovic): Hi [~paulo] I would really appreciate your review here https://github.com/apache/cassandra/pull/1184/files > Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest > ------------------------------------------------------------------------------ > > Key: CASSANDRA-16911 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16911 > Project: Cassandra > Issue Type: Improvement > Components: Local/Snapshots > Reporter: Stefan Miklosovic > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 4.2 > > Time Spent: 40m > Remaining Estimate: 0h > > While creating an ephemeral snapshot, a marker file is created at disk in a > respective snapshot directory. This is not necessary anymore as we have > introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag > there. By putting the information if a snapshot is ephemeral or not into > SnapshotManifest, we simplify and "clean up" the snapshotting process and > related codebase. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org