[
https://issues.apache.org/jira/browse/CASSANDRA-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562669#comment-17562669
]
Ekaterina Dimitrova commented on CASSANDRA-17725:
-------------------------------------------------
{quote}And a bug I found that I want to ask [~jolynch] for advise as he was
involved into adding that property:
[https://github.com/apache/cassandra/commit/9f56bf4ca7fdb61ad09e5f2ad09b87cd01e0716b#diff-77707d0908c31940828b6425dcb09a7409827db99b48c371f71c63294dfe1562L444-R444]
—> please check, I believe this change is a bug. The Converter used for that
property with the pre-4.0 format does not allow negatives and we will always
have 0 in AutoSavingCache where we check for negatives and not 0. The test
where this was set to -1 is testKeyCacheLoadZeroCacheLoadTime and it works
without an issue with 0. . For [~jolynch] - long story short we prohibited the
usage of negatives as it was considered a bug in 4.1. But it seems different
here with this property. If negatives and 0 will do the same (I am not sure,
didn’t dive too much into that patch), maybe we can use the
_NEGATIVE_SECONDS_DURATION_ converter from the Converters class we added for
validation_preview_purge_head_start which will convert a negative number to 0
in 4.1 and tell people from now on will use 0 to disable but at the same time
if they upgrade with negative and the old value format and property name, they
will be able to set negative number which will be migrated internally to 0. I
am really not completely sure, what do others think?
{quote}
Or maybe [~hari_nv] or [~marcuse] can help me with this question as you were
also working on CASSANDRA-14898 where the property was added?
> Add a flag for throughput in MiB/s for nodetool setstreamthroughput,
> getstreamthroughput, setinterdcstreamthroughput and
> getinterdcstreamthroughput
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17725
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> As we agreed not to add new JMX methods for the new config on the mailing
> list, we need at least new flags for setstreamthroughput and
> interdcstreamthroughput for the two 4.0 parameters to be set/get also in MiB,
> not only in megabits.
> Thus we will have the option either to use the old version for those 2, or to
> be able to set/get in MiB all 4 streaming parameters. As of 4.1 supported
> units for DataRateSpec are MiB/s, B/s, KiB/s, megabit is only for legacy from
> 4.0 - backward compatibility.
> To be sure we satisfy the requirements around the latest discussions about
> backward compatibility in tools, I will use this ticket also to make a final
> pass on the unit changes done, to ensure the probe output is not affected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
